On Mon, Feb 17, 2014 at 1:26 PM, Kirill Yukhin <kirill.yuk...@gmail.com> wrote:
>> >> Please don't change srcp pattern, it should be defined similar to >> >> vrcpss (aka sse_vmrcpv4sf). You need to switch operand order >> >> elsewhere. >> > >> > No, you are correct. Operands should be swapped as in your patch. >> >> Eh, sorry that after some more thinking, I have to again revert this >> decision. >> >> The srcp pattern should remain as is, and you should swap operands in >> avx512fintrin.h instead: > > In the bottom there's updated patch. > > Added "sse" type. mem operand made second. > Built-ins & tests fixed. > > Testing in progress. > > Is it ok for mainline if pass? No, you got operand order wrong. To correctly calculate "memory" attribute, all "sse" type insns expect the operands in the way sse_vmrcpv4sf2 is defined. You should keep nonimmedate operand as operand_1 and switch operands in builtins and insn mnemonics to fulfill required operand order *in the pattern*. (Please also post ChangeLog for review). Uros.
