On Tue, 25 Feb 2014, Jan Hubicka wrote:

> > 
> > This fixes the ICE on our regular -flto-partition=none testers
> > which sees an edge w/o call-stmt after inlining (see the PR
> > for details).  I'm not sure this is supposed to happen but the
> > following re-instantiates the guard to inline_update_overall_summary
> > which was present before the last change to that area.
> > 
> > LTO bootstrap / regtest running on x86_64-unknown-linux-gnu, ok?
> 
> > 
> > Thanks,
> > Richard.
> > 
> > 2014-02-25  Richard Biener  <rguent...@suse.de>
> > 
> >     PR ipa/60327
> >     * ipa.c (walk_polymorphic_call_targets): Properly guard
> >     call to inline_update_overall_summary.
> 
> Ah yes, that is OK! Indeed inline summaries are freed after inlining during
> normal compilation. During WPA they are kept so lto-partitioning can use them.

One more reason to drop -flto-partition=none (and introduce
-flto-partition=one)?  IMHO this different path through the
LTO pipeline is not worth maintaining.

Richard.

Reply via email to