On Mar 28, 2014, at 3:16 AM, K_s, Vishnu <vishnu....@atmel.com> wrote:
> The tests added in gcc.dg/tree-ssa/isolate-*.c is failing for AVR target,
> Because the isolate erroneous path pass needs -fdelete-null-pointer-checks
> option to be enabled. For AVR target that option is disabled, this cause 
> the tests to fail. Following Patch skip the isolate-* tests if 
> "keeps_null_pointer_checks" is true. 

So I didn’t see a checkin, and I don’t see an Ok?  Each patch should have one 
or the other…  Without an Ok? I assume it’s been checked in, with an Ok? I take 
that as a review request.

I’ll assume you forgot the Ok?, Ok.

Since the AVR people are fairly active, I’ll let them check it in; gives them 
the opportunity to further consider it.

> 2014-03-28  Vishnu K S <vishnu....@atmel.com >
> 
>       * gcc/testsuite/gcc.dg/tree-ssa/isolate-1.c: Skip test for AVR 
>       * gcc/testsuite/gcc.dg/tree-ssa/isolate-2.c: Ditto 
>       * gcc/testsuite/gcc.dg/tree-ssa/isolate-3.c: Ditto
>       * gcc/testsuite/gcc.dg/tree-ssa/isolate-4.c: Ditto
>       * gcc/testsuite/gcc.dg/tree-ssa/isolate-5.c: Ditto

Reply via email to