On Mon, Apr 28, 2014 at 12:18:05PM +0100, Kyrill Tkachov wrote:
> Hi all,
>
> I noticed this test is failing on aarch64:
>
> FAIL: gcc.dg/pr60114.c (test for warnings, line 7)
> FAIL: gcc.dg/pr60114.c (test for warnings, line 8)
> FAIL: gcc.dg/pr60114.c (test for warnings, line 21)
> FAIL: gcc.dg/pr60114.c (test for warnings, line 22)
> FAIL: gcc.dg/pr60114.c (test for warnings, line 23)
> FAIL: gcc.dg/pr60114.c (test for warnings, line 25)
> FAIL: gcc.dg/pr60114.c (test for excess errors)
>
> The test was recently added with
> http://gcc.gnu.org/ml/gcc-patches/2014-02/msg00592.html
Sorry, I tested x86_64, both -m64 and -m32, but I don't test ARM.
> The offending code is of the form:
>
>
> const char z[] = {
> [0] = 0x100, /* { dg-warning "9:overflow in implicit constant conversion" }
> */
> [2] = 0x101, /* { dg-warning "9:overflow in implicit constant conversion" }
> */
> };
>
>
> On aarch64 (and arm) chars are unsigned by default so instead we get
> the warning "large integer implicitly truncated to unsigned type".
>
> This patch explicitly uses signed chars in the test as suggested by richi in
> the PR.
>
> Ok for trunk?
Looks good.
Marek
