Tom de Vries <tom_devr...@mentor.com> writes:
> On 28-04-14 12:26, Richard Sandiford wrote:
>> Tom de Vries <tom_devr...@mentor.com> writes:
>>> On 27-04-14 12:27, Richard Sandiford wrote:
>>>> Tom de Vries <tom_devr...@mentor.com> writes:
>>>>> mips_emit_call_insn (rtx pattern, rtx orig_addr, rtx addr, bool lazy_p)
>>>>> {
>>>>> rtx insn, reg;
>>>>>
>>>>> - insn = emit_call_insn (pattern);
>>>>> + emit_call_insn (pattern);
>>>>> + insn = last_call_insn ();
>>>>>
>>>>> if (TARGET_MIPS16 && mips_use_pic_fn_addr_reg_p (orig_addr))
>>>>> {
>>>>
>>>> This change isn't necessary; emit_call_insn is defined to return a
>>>> CALL_INSN.
>>>>
>>>
>>> I dropped this change, as well as the change in the untyped_call expand, I
>>> realized it's unnecessary.
>>
>> Why was the untyped_call part unnecessary?
>>
>
> The define_expand "untyped_call" uses GEN_CALL, which uses
> define_expand "call", which uses mips_expand_call, which uses
> mips_emit_call_insn, which adds the required clobbers.
Ah, yeah. In that case please keep mips_emit_call_insn static.
OK with that change, although please remove -O1 if the agreement
is that "-O1 -fuse-call-save" should work.
Thanks,
Richard
