On Fri, 25 Apr 2014, Marek Polacek wrote:
> Another minor fix: use loc instead of input_location. Also add
> missing OPT_Wpedantic.
Why do you say it's missing? A default pedwarn generally means "this is
dubious code, not allowed by ISO C, but we don't want to make it a hard
error" (and the trend is more to making such things hard errors, rather
than limiting them to -pedantic).
For the *first* such change ("not computable at load time"), I think it's
already conditional on (pedantic && !flag_isoc99), based on the setting of
require_constant_elements, and so using OPT_Wpedantic is appropriate. But
I think the second represents an undesirable change to how the compiler
behaves - code such as
int f();
int a = 1 ? 1 : f();
*should* be diagnosed by default rather than needing -pedantic. If you
think this case also only affects for form of diagnostics that were
already only given if pedantic, please explain further why this is the
case.
--
Joseph S. Myers
jos...@codesourcery.com
