Re: [buildrobot][patch] picochip: Fix int -> enum machine_mode fallout

[Jeff Law]

On 05/04/14 14:37, Jan-Benedict Glaw wrote:

Hi!

I propose the following patch to cure this:

g++ -c   -g -O2 -DIN_GCC  -DCROSS_DIRECTORY_STRUCTURE  -fno-exceptions 
-fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings 
-Wcast-qual -Wmissing-format-attribute -Woverloaded-virtual -pedantic 
-Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -Werror -fno-common 
 -DHAVE_CONFIG_H -I. -I. -I../../../gcc/gcc -I../../../gcc/gcc/. 
-I../../../gcc/gcc/../include -I../../../gcc/gcc/../libcpp/include 
-I/opt/cfarm/mpc/include  -I../../../gcc/gcc/../libdecnumber 
-I../../../gcc/gcc/../libdecnumber/dpd -I../libdecnumber 
-I../../../gcc/gcc/../libbacktrace    -o picochip.o -MT picochip.o -MMD -MP -MF 
./.deps/picochip.TPo ../../../gcc/gcc/config/picochip/picochip.c
In file included from ../../../gcc/gcc/rtl.h:24:0,
                  from ../../../gcc/gcc/config/picochip/picochip.c:27:
../../../gcc/gcc/config/picochip/picochip.c: In function ‘int 
picochip_regno_nregs(int, int)’:
../../../gcc/gcc/machmode.h:183:32: error: invalid conversion from ‘int’ to 
‘machine_mode’ [-fpermissive]
         ? mode_size_inline (MODE) : mode_size[MODE]))
                                 ^
../../../gcc/gcc/config/picochip/picochip.c:1247:12: note: in expansion of 
macro ‘GET_MODE_SIZE’
    return ((GET_MODE_SIZE (mode) + UNITS_PER_WORD - 1) / UNITS_PER_WORD);
             ^
../../../gcc/gcc/config/picochip/picochip.c: In function ‘int 
picochip_class_max_nregs(int, int)’:
../../../gcc/gcc/machmode.h:183:32: error: invalid conversion from ‘int’ to 
‘machine_mode’ [-fpermissive]
         ? mode_size_inline (MODE) : mode_size[MODE]))
                                 ^
../../../gcc/gcc/config/picochip/picochip.c:1254:16: note: in expansion of 
macro ‘GET_MODE_SIZE’
    int size = ((GET_MODE_SIZE (mode) + UNITS_PER_WORD - 1) / UNITS_PER_WORD);
                 ^
make[2]: *** [picochip.o] Error 1




2014-05-04  Jan-Benedict Glaw  <jbg...@lug-owl.de>

gcc/
        * config/picochip/picochip-protos.h (picochip_regno_nregs): Change
        int argument to machine_mode.
        (picochip_class_max_nregs): Dito.
        * config/picochip/picochip.c (picochip_regno_nregs): Dito.
        (picochip_class_max_nregs): Dito.

Seems reasonable to me.  s/Dito/Ditto/



Jeff