On 12 May 2014 10:06, Christian Bruel <christian.br...@st.com> wrote: > Just saw the Jeff's approval for the RTL part. Sorry for the crossed answers > > remains the target maintainers. Joern, Kaz ? > > Many thanks. > > Christian > > On 05/12/2014 10:44 AM, Christian Bruel wrote: >> Hello, >> >> I'd still wish to ping for the following set of patches. Those changes >> does not impact other targets than SH4 but, as suggested by Joern, I >> have hooked the macros and moved the SH4A specific support to the target >> parts (so a different target can eventually implement other models than >> dual mode). >> >> Patch2 only does very little restructuring but if is not interesting >> enough for all targets, patch 1 should not be that intrusive. >> >> For RTL middle end and (X86, SH, Epiphany) target reviewers, >> >> Many thanks, >> >> Christian >> >> On 04/28/2014 10:08 AM, Christian Bruel wrote: >>> Hello, >>> >>> I'd like to ping the following patches >>> >>> [Hookize mode-switching] >>> http://gcc.gnu.org/ml/gcc-patches/2014-04/msg01003.html >>> >>> [Add new hooks to support toggle and SH4A fpchg instruction] >>> http://gcc.gnu.org/ml/gcc-patches/2014-04/msg01005.html
Sorry, I only saw the first part and thought I' d need to wait till I see the second part - and I somehow missed that. I think the previous known mode should be passed to the TARGET_MODE_EMIT hook - no need to have extra hooks for toggling, and, as I mentioned earlier, fixating on the toggle is actually an SH artifact - other ports have multi-way modes settings that can benefit from knowing the previous mode.