On Wed, 2014-05-14 at 12:09 -0600, Jeff Law wrote: > On 05/12/14 15:36, David Malcolm wrote: > [ ... Big Snip ... ] > This series of 3 patches is approved.
FWIW, I've been working my way through the remainder of the patches, updating them to take account of the largely mechanical changes [1] for the v4 approach; so far I've done up to: "[PATCH 28/89] Introduce gimple_eh_else". and FWIW I've backed these up here: http://dmalcolm.fedorapeople.org/gcc/patch-backups/gimple-classes/v4-patches/ in case of hard drive failure or me messing up a git command along the way. [2] I'm not expecting reviews of the those patches at this time. I believe these are all largely "grandfathered in" from the reviews you've already done; I'm mostly posting here as a heads-up of what the code will look like, and in case of catastrophe (indeed I've only occasionally bootstrapped®rested as I've gone along). After all 89 are done, I can take a look at the accessor renaming ideas Richi asked me to investigate. I'm also experimenting with trying a similar thing for RTL. Dave [1] though sadly there's a lot of handwritten manipulation needed to them, due to "bitrot" due to the gimple -> gimple* transition, so this has been rather tedious. Basically every line in each of the patches has needed some kind of manual fixup :( [2] this is via a huge "git rebase" command which means there's a few FIXME commits in there for when I forgot something.