On 05/18/14 09:33, John David Anglin wrote:
The attached change appears to fix PR middle-end/61141. On PA, we can get
deleted insn notes in call sequences. The attached change checks to
make sure we have
a valid insn before calling reset_insn_used_flags and verify_insn_sharing.
Tested on hppa-unknown-linux-gnu, hppa2.0w-hp-hpux11.11 and
hppa64-hp-hpux11.11.
OK for trunk?
Maybe :-)
c#1 you incluide a blob of RTL, but it's not clear where insn 238 was to
begin with. ie, was it inside a SEQUENCE or somewhere else?
In c#2 you indicate we can get this stuff when an insn in a delay slot
sequence is deleted. Where/when are those insns being deleted?
Presumably the backends know enough to handle deleted insns in delay
slot sequences?!? It's been a long time since I looked at that code in
detail, so if you already know it's safe, just say "it's safe" and I'll
believe you :-) Otherwise a bit of digging may be needed.
My preference would be to remove these insns from the RTL chain, but if
that's not going to be reasonably feasible, then we'll probably need to
go with something like your patch.
Jeff
