Thanks for the reviews.

Jeff Law <l...@redhat.com> writes:
> Does the comment before indep_constraints in genoutput need updating? 
> The constraints in common.md are machine independent, but aren't listed 
> in indep_constraints in genoutput.c

Yeah, good catch.  I changed it to:

/* All machine-independent constraint characters (except digits) that
   are handled outside the define*_constraint mechanism.  */
static const char indep_constraints[] = ",=+%*?!#&g";

Also in genpreds.c:

/* Contraint letters that have a special meaning and that cannot be used
   in define*_constraints.  */
static const char generic_constraint_letters[] = "g";

Richard

Reply via email to