On Tue, 17 Jun 2014, Sylvestre Ledru wrote: > OK. I will do that. > We should test the following: > * default => run just -Wreturn-type > * -Wreturn-type => Run both > * -Wreturn-type + -Wmissing-return => Run both > * -Wno-return-type + -Wmissing-return => Run just the second one > * -Wno-return-type + -Wno-missing-return => Run none > Do you see any other?
That looks like the right things to test, if there are no changes for anything other than those options. > Besides that, are you OK with my changes? (with the tests updated) The tests are key to reviewing whether the code changes actually do the right thing. -- Joseph S. Myers jos...@codesourcery.com