On 06/11/14 15:15, Peter Bergner wrote:
I'd like to ping the following patch that fixes PR57653.  This did
bootstrap and regtest with no regressions on powerpc64-linux.

     https://gcc.gnu.org/ml/gcc-patches/2014-04/msg01571.html

Is this ok for trunk, 4.9 and 4.8?
Whee, fun.

So this led me to an interesting exchange between Per & DJ on some of Per's changes in this space.

Sadly, it doesn't look like Per checked in any tests for the problems DJ was running into.

I hate to ask Peter, but can you add some testcases? These messages have the originals which led to the unsightly code we have now.

https://gcc.gnu.org/ml/gcc-patches/2003-10/msg02694.html
https://gcc.gnu.org/ml/gcc-patches/2003-11/msg00163.html

I know 57653's problem is specific to the stdc-predef that's included in glibc-2.17 and later, but that's becoming relatively common at this point. I think c#2 has the testcase.

Approved with the tests added.

Thanks and sorry for the delay.

Jeff

Reply via email to