> On 06/24/2014 02:18 PM, Jan Hubicka wrote:
> >>On 06/23/2014 04:25 PM, Jan Hubicka wrote:
> >>>   * class.c (check_methods, create_vtable_ptr, determine_key_method,
> >>>   add_vcall_offset_vtbl_entries_1): Guard VINDEX checks by FUNCTION_DECL 
> >>> check.
> >>
> >>These changes are unnecessary: TYPE_METHODS is a list of functions.
> >
> >I just double checked and there are template decls in the list, too. Those
> >always have VINDEX NULL, but with my change they naturally ICEs when you 
> >query
> >it.  I am re-testing the patch with the checks added back and intend to 
> >commit.
> 
> Ah, of course.  OK.
Thanks a lot!

Honza

Reply via email to