On Thu, Jun 26, 2014 at 12:40 AM, Richard Biener
<richard.guent...@gmail.com> wrote:
> On Wed, Jun 25, 2014 at 4:21 PM, Teresa Johnson <tejohn...@google.com> wrote:
>> On Tue, May 13, 2014 at 8:19 AM, Xinliang David Li <davi...@google.com>
>> wrote:
>>> On Tue, May 13, 2014 at 1:39 AM, Richard Biener
>>> <richard.guent...@gmail.com> wrote:
>>>> On Fri, May 9, 2014 at 5:54 PM, Teresa Johnson <tejohn...@google.com>
>>>> wrote:
>>>>> I discovered that the support for the documented -fdump-* options
>>>>> "optimized", "missed", "note" and "optall" was missing. Added that and
>>>>> fixed a minor typo in the documentation.
>>>>>
>>>>> Bootstrapped and tested on x86-64-unknown-linux-gnu. Ok for trunk?
>>>>
>>>> I'm not sure they were intented for user-consumption. ISTR they
>>>> are just an implementation detail exposed by -fopt-info-X (which is
>>>> where they are documented).
>>>>
>>>> The typo fix is ok, also adding a comment before the dump flags
>>>> definition to the above fact.
>>>>
>>>> David, do I remember correctly?
>>>
>>> I remember we talked about content filtering dump flags. Things like
>>>
>>> -fdump-xxx-ir <-- dump IR only
>>> -fdump-xxx-transformation <-- optimization note
>>> -fdump-xxx-debug <-- other debug traces
>>>
>>> Other than that, now I think 'details' and 'all' seem redundant.
>>> 'verbose' flag/modifier can achieve the same effect depending on the
>>> context.
>>>
>>> -fdump-xxx-ir-verbose <-- dump IR, and turn on IR modifiers such as
>>> vops, lineno, etc
>>> -fdump-xxx-transforamtion-verbose <-- dump transformations + missed
>>> optimizations + notes
>>> -fdump-xxx-debug-verbose <-- turn on detailed trace.
>>
>> The above proposal seems fine to me as a longer-term direction, but
>> also seems somewhat orthogonal to the issue my patch is trying to
>> solve in the short term, namely inconsistent documentation and
>> behavior:
>>
>> 1) "optimized", "missed", "note" and "optall" are documented as being
>> sub-options for -fdump-tree-* in doc/invoke.texi, but not implemented.
>> 2) "optimized", "missed", "note" and "optall" are however enabled via
>> -fdump-tree-all
>>
>> Could we at least fix these issues in the short term, as it doesn't
>> affect the documented behavior (but rather adds the documented
>> behavior)?
>
> Sure.
>
> Richard.
Thanks, retested and committed as r212040.
Teresa
>
>> Thanks,
>> Teresa
>>
>>>
>>> thanks,
>>>
>>> David
>>>
>>>
>>>>
>>>> Thanks,
>>>> Richard.
>>>>
>>>>> Thanks,
>>>>> Teresa
>>>>>
>>>>> 2014-05-09 Teresa Johnson <tejohn...@google.com>
>>>>>
>>>>> * doc/invoke.texi: Fix typo.
>>>>> * dumpfile.c: Add support for documented -fdump-* options
>>>>> optimized/missed/note/optall.
>>>>>
>>>>> Index: doc/invoke.texi
>>>>> ===================================================================
>>>>> --- doc/invoke.texi (revision 210157)
>>>>> +++ doc/invoke.texi (working copy)
>>>>> @@ -6278,7 +6278,7 @@ passes).
>>>>> @item missed
>>>>> Enable showing missed optimization information (only available in certain
>>>>> passes).
>>>>> -@item notes
>>>>> +@item note
>>>>> Enable other detailed optimization information (only available in
>>>>> certain passes).
>>>>> @item =@var{filename}
>>>>> Index: dumpfile.c
>>>>> ===================================================================
>>>>> --- dumpfile.c (revision 210157)
>>>>> +++ dumpfile.c (working copy)
>>>>> @@ -107,6 +107,10 @@ static const struct dump_option_value_info dump_op
>>>>> {"nouid", TDF_NOUID},
>>>>> {"enumerate_locals", TDF_ENUMERATE_LOCALS},
>>>>> {"scev", TDF_SCEV},
>>>>> + {"optimized", MSG_OPTIMIZED_LOCATIONS},
>>>>> + {"missed", MSG_MISSED_OPTIMIZATION},
>>>>> + {"note", MSG_NOTE},
>>>>> + {"optall", MSG_ALL},
>>>>> {"all", ~(TDF_RAW | TDF_SLIM | TDF_LINENO | TDF_TREE | TDF_RTL |
>>>>> TDF_IPA
>>>>> | TDF_STMTADDR | TDF_GRAPH | TDF_DIAGNOSTIC | TDF_VERBOSE
>>>>> | TDF_RHS_ONLY | TDF_NOUID | TDF_ENUMERATE_LOCALS |
>>>>> TDF_SCEV)},
>>>>>
>>>>>
>>>>> --
>>>>> Teresa Johnson | Software Engineer | tejohn...@google.com | 408-460-2413
>>
>>
>>
>> --
>> Teresa Johnson | Software Engineer | tejohn...@google.com | 408-460-2413
--
Teresa Johnson | Software Engineer | tejohn...@google.com | 408-460-2413
