On 06/26/14 02:18, Rainer Orth wrote:
Ok for mainline?

Could you please reformat the c_fix_arg's and test-text to be "here strings" a 
la:

    c_fix_arg = <<- _EOS_
        #undef  signbit
        #define signbit(x)      (sizeof(x) == sizeof(float) \
        \                          ? __builtin_signbitf(x) \
        \                          : sizeof(x) == sizeof(long double) \
        \                            ? __builtin_signbitl(x) \
        \                            : __builtin_signbit(x))";
        _EOS_;

I changed the "here string" thingy to eat that tab-backslash
and leave the rest of the tabs a few years ago.
That is considerably more readable than:

    c_fix_arg = "#undef\tsignbit\n"
                "#define\tsignbit(x)\t(sizeof(x) == sizeof(float) \\\n"
                "\t\t\t   ? __builtin_signbitf(x) \\\n"
                "\t\t\t   : sizeof(x) == sizeof(long double) \\\n"
                "\t\t\t     ? __builtin_signbitl(x) \\\n"
                "\t\t\t     : __builtin_signbit(x))";

and the other two are worse.  Thank you!

Reply via email to