On Jul 2, 2014, at 10:52 AM, Nathan Froyd <froy...@mozilla.com> wrote: > ----- Original Message ----- >> /aux/hubicka/firefox/netwerk/sctp/datachannel/DataChannel.h:64:0: warning: >> field ‘mSpa’ (of type ‘struct BufferedMsg’) violates one definition rule >> [-Wodr] > > Can we reword this warning? The "of type 'struct BufferedMsg'" could be > easily taken to mean that the type of the field is 'struct BufferedMsg', > rather than the intended meaning. Perhaps "within type 'struct BufferedMsg’"?
type is redundant with struct, all structs are types, so "within ‘struct” would be slightly shorter, as would just “in ‘struct”.
