On Fri, Jul 4, 2014 at 2:11 PM, Jan-Benedict Glaw <jbg...@lug-owl.de> wrote: > On Wed, 2014-06-25 08:55:57 -0700, augustine.sterl...@gmail.com > <augustine.sterl...@gmail.com> wrote: >> On Tue, Jun 24, 2014 at 10:20 PM, Jan Hubicka <hubi...@ucw.cz> wrote: >> > > This is the xtensa fallout, see >> > > http://toolchain.lug-owl.de/buildbot/show_build_details.php?id=272418 >> > > >> > > g++ -c -g -O2 -DIN_GCC -DCROSS_DIRECTORY_STRUCTURE -fno-exceptions >> > > -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing >> > > -Wwrite-strings -Wcast-qual -Wmissing-format-attribute >> > > -Woverloaded-virtual -pedantic -Wno-long-long -Wno-variadic-macros >> > > -Wno-overlength-strings -fno-common -DHAVE_CONFIG_H -I. -I. >> > > -I/home/jbglaw/repos/gcc/gcc -I/home/jbglaw/repos/gcc/gcc/. >> > > -I/home/jbglaw/repos/gcc/gcc/../include >> > > -I/home/jbglaw/repos/gcc/gcc/../libcpp/include >> > > -I/home/jbglaw/repos/gcc/gcc/../libdecnumber >> > > -I/home/jbglaw/repos/gcc/gcc/../libdecnumber/dpd -I../libdecnumber >> > > -I/home/jbglaw/repos/gcc/gcc/../libbacktrace -o insn-preds.o -MT >> > > insn-preds.o -MMD -MP -MF ./.deps/insn-preds.TPo insn-preds.c >> > > /home/jbglaw/repos/gcc/gcc/config/xtensa/predicates.md: In function ‘int >> > > call_insn_operand_1(rtx, machine_mode)’: >> > > /home/jbglaw/repos/gcc/gcc/config/xtensa/predicates.md:113:57: error: >> > > cannot convert ‘const char*’ to ‘tree’ in assignment >> > > /home/jbglaw/repos/gcc/gcc/config/xtensa/predicates.md:119:46: error: >> > > cannot convert ‘const char*’ to ‘tree’ in assignment >> > > make[1]: *** [insn-preds.o] Error 1 >> > Should be fixed by this (and I see in my prevoius mail I wanted >> > TREE_STRING_POINTER) >> >> [resend due to gmail's stupid html-by-default] >> >> This patch looks correct to me, but I haven't watched quite enough of >> the underlying change to know that replacing the strcmp with pointer >> equality is really the right thing. >> >> If it is, approved for Xtensa. > > *ping* > > As Jan wrote it, I *guess* it probably is (haven't checked.)
Approved.
