On 08/03/14 07:40, Richard Sandiford wrote:
gcc/
        * alias.c: Include rtl-iter.h.
        (refs_newer_value_cb): Delete.
        (refs_newer_value_p): Use FOR_EACH_SUBRTX instead of for_each_rtx.
OK.

Just a few notes.

1. I really like when we can make these callbacks go away :-)

2. When the callbacks go away, the opaque data we pass them goes away as well which is good for readability.

3. That opaque data is often a local and we had to take its address and thus force it to memory. With the direct uses in the updated code those locals don't have to live in memory, which is goodness.

Anyway, just wanted to point those out for anyone looking at this in parallel or in the future.

jeff

Reply via email to