On Fri, 15 Aug 2014, Manuel L?pez-Ib??ez wrote:

> Hi,
> 
> This patch moves the location of various Wformat warnings from
> pointing to the first character of the function name (such as printf)
> to the actual format string. This is specially useful when you have
> something like
> 
> printf (cond ? "format 1" : "format 2");
> 
> It also moves (some) of the warnings about too many arguments to the
> first argument that is unused. Since the format string and/or the
> arguments might not be expressions or strings, this doesn't always
> work and then we are back to the status-quo.
> 
> This is anyway a first step. I have some patches to point within the
> format string for some cases. This is why I added column markers to
> testcases even if we don't actually improve the location: it  will
> help us to identify testcases that need updating as the location info
> improves.
> 
> Unfortunately, reaching the level of Clang seems well beyond the time
> I can dedicate to this, so any help would be appreciated.
> 
> OK for trunk?

OK.

-- 
Joseph S. Myers
jos...@codesourcery.com

Reply via email to