Ah... thanks for the clarification. Fixed (and committed).
Andrew
On Thu, Aug 21, 2014 at 4:26 AM, Paolo Carlini <paolo.carl...@oracle.com> wrote:
> Hi Andrew,
>
>
> On 08/20/2014 11:08 PM, Andrew Sutton wrote:
>>>
>>> On 08/20/2014 08:56 PM, Andrew Sutton wrote:
>>>>
>>>> + return VAR_P (decl)
>>>> + && DECL_LANG_SPECIFIC (decl)
>>>> + && DECL_DECLARED_CONCEPT_P (decl);
>>>
>>> this is brittle from the formatting point of view. Please double check in
>>> detail what I'm going to say, but I think that in such cases you simply
>>> want
>>> to wrap the whole thing in round parentheses.
>>
>> Sorry, did you just mean to wrap the entire conjunction in parens? I'm
>> trying to find the formatting guidelines to check, but not succeeding
>> at the moment.
>
> Yes, I meant the whole conjunction, sorry about my sloppy language. In terms
> of GNU coding standards:
>
> http://www.gnu.org/prep/standards/standards.html#Formatting
>
> toward the end of the section, for example.
>
> Paolo.
Index: gcc/cp/decl.c
===================================================================
--- gcc/cp/decl.c (revision 214241)
+++ gcc/cp/decl.c (working copy)
@@ -6264,9 +6264,9 @@ value_dependent_init_p (tree init)
static inline bool
is_concept_var (tree decl)
{
- return VAR_P (decl)
- && DECL_LANG_SPECIFIC (decl)
- && DECL_DECLARED_CONCEPT_P (decl);
+ return (VAR_P (decl)
+ && DECL_LANG_SPECIFIC (decl)
+ && DECL_DECLARED_CONCEPT_P (decl));
}
/* Finish processing of a declaration;
