On Wed, Sep 17, 2014 at 04:39:00PM +0200, Andi Kleen wrote: > Ok, this should fix it: > > I'll commit it as obvious after testing unless there are objections.
This isn't sufficient. If -mfentry isn't compatible with -m32 -fpic, supposedly you need something like (untested): /* { dg-do compile { target { { *-*-linux* } && { nonpic || ! { ia32 } } } } } */ or similar (dunno about -mx32 -fpic, whether it is supposed to work or not). Otherwise, if somebody tests (and some people do) with make check-gcc RUNTESTFLAGS='--target_board=unix\{-m32,-m32/-fpic,-m64,-m64/-fpic\}' or similar, there could be failures. Just test your patch with make check-gcc RUNTESTFLAGS='--target_board=unix\{-m32,-m32/-fpic,-m64,-m64/-fpic\} i386.exp=fentry*.c' in addition to normal testing... > --- a/gcc/testsuite/gcc.target/i386/fentry-override.c > +++ b/gcc/testsuite/gcc.target/i386/fentry-override.c > @@ -1,5 +1,5 @@ > /* Test -mfentry override */ > -/* { dg-do compile } */ > +/* { dg-do compile { target { *-*-linux* } } } */ > /* { dg-options "-mfentry" } */ > /* { dg-final { scan-assembler-not "__fentry__" } } */ > /* Origin: Andi Kleen */ > diff --git a/gcc/testsuite/gcc.target/i386/fentry.c > b/gcc/testsuite/gcc.target/i386/fentry.c > index bd3db13..2222888 100644 > --- a/gcc/testsuite/gcc.target/i386/fentry.c > +++ b/gcc/testsuite/gcc.target/i386/fentry.c > @@ -1,5 +1,5 @@ > /* Test -mfentry */ > -/* { dg-do compile } */ > +/* { dg-do compile { target { *-*-linux* } } } */ > /* { dg-options "-fprofile -mfentry" } */ > /* { dg-final { scan-assembler "__fentry__" } } */ > /* Origin: Andi Kleen */ > > > -- > a...@linux.intel.com -- Speaking for myself only. Jakub