On 09/18/2014 03:01 PM, Jakub Jelinek wrote:
On Mon, Sep 15, 2014 at 01:46:14PM +0400, Yury Gribov wrote:
On 09/08/2014 06:29 PM, Yury Gribov wrote:
Kasan developers has asked for an option to override offset of Asan
shadow memory region. This should simplify experimenting with memory
layouts on 64-bit architectures.

I've bootstrapped and regtested this on x64.

Ok to commit?

I don't like it at all.  For the kernel-address perhaps it might make sense
as a param, but for userland, as it is an ABI changing option, I'm afraid
people would start to create objects/shared libraries/binaries with
ABI incompatible values.
So, if you need it for kernel, use a param that can be eventually dropped,
and limit it to kernel-address mode only.

Problem with params is that they are ints so won't work for 64-bit platforms. How about aborting if -fasan-shadow-offset is supplied without -fsanitize=kernel-address?

-Y

Reply via email to