On Tue, Sep 23, 2014 at 7:16 AM, Jakub Jelinek <ja...@redhat.com> wrote: > On Mon, Sep 22, 2014 at 11:44:57AM -0700, Konstantin Serebryany wrote: >> re-sending with the patch compressed: >> >> =============== gcc/testsuite/ChangeLog >> 2014-09-22 Kostya Serebryany <k...@google.com> >> >> Update to match the changed asan API. >> * asan.c (asan_global_struct): Update the __asan_global definition >> to match >> the new API. > > Please make sure you are using tabs instead of spaces in the ChangeLog > entries. The above line is too long, please break it earlier. > >> (asan_add_global): Ditto. > > I'll handle creation of location aggregates as follow-up. > >> * sanitizer.def (BUILT_IN_ASAN_INIT): Rename __asan_init_v3 >> to __asan_init_v4. >> >> =============== libsanitizer/ChangeLog >> 2014-09-22 Kostya Serebryany <k...@google.com> >> >> * All source files: Merge from upstream r218156. >> * asan/Makefile.am (asan_files): Added new files. >> * asan/Makefile.in: Regenerate. >> * ubsan/Makefile.am (ubsan_files): Added new files. >> * ubsan/Makefile.in: Regenerate. >> * tsan/Makefile.am (tsan_files): Added new files. >> * tsan/Makefile.in: Regenerate. >> * sanitizer_common/Makefile.am (sanitizer_common_files): Added >> new >> files. >> * sanitizer_common/Makefile.in: Regenerate. >> * asan/libtool-version: bump the libasan SONAME. > > Capital B. > > Ok for trunk, from quick skimming it shouldn't be that bad for portability > this time.
Fixed all, committed. > > OT, will you please look at the underaligned asan malloc etc.? GCC assumes > that even malloc (1) or malloc (7) is sizeof (void *) aligned on Linux > (and can and will assume 2 * sizeof (void *) alignment hopefully soon). What's wrong here? I am pretty confident that asan's malloc always returns 16-aligned pointers. --kcc > > Jakub
