On 25 September 2014 16:18, Richard Henderson <r...@redhat.com> wrote: > On 09/25/2014 08:05 AM, James Greenhalgh wrote: >> >> On Fri, Sep 19, 2014 at 05:57:06PM +0100, Richard Henderson wrote: >>> On 09/11/2014 01:29 AM, James Greenhalgh wrote: >>>> +;; Predicates used by the various SIMD shift operations. These >>>> +;; fall in to 3 categories. >>>> +;; Shifts with a range 0-(bit_size - 1) (aarch64_simd_shift_imm) >>>> +;; Shifts with a range 1-bit_size (aarch64_simd_shift_imm_offset) >>>> +;; Shifts with a range 0-bit_size (aarch64_simd_shift_imm_bitsize) >>>> +(define_predicate "aarch64_simd_shift_imm_qi" >>>> + (and (match_code "const_int") >>>> + (match_test "aarch64_simd_const_bounds (op, 0, 7)"))) >>> >>> The function call should be removed and this should be written as >>> >>> (match_test "IN_RANGE (ival, 0, 7)") >>> >> >> Quite right, updated as attached. >> >> Cross-tested for aarch64-none-elf with no issues. >> >> OK?
OK /Marcus
