On 09/27/14 16:03, Segher Boessenkool wrote:
On Mon, Sep 22, 2014 at 04:20:12PM -0600, Jeff Law wrote:
Can you add a testcase which shows the 3-insn combination from PR62151
applying?
I've tried to make a stable future-proof testcase that does such a three-insn
combination. Not easy at all.
But now it dawns on me: do you just want the actual testcase from the PR?
(Well, fixed so that it is valid C, I suppose). With a test that combine
does its job, of course? Not sure how to test that, but maybe I'll learn.
Or is a test showing the testcase working after the change good enough?
It's going to be hard to totally future proof this kind of test and make
it independent across every target, etc.
In those cases, I just ask you do something reasonable. That can
include making the test only applicable on a small number of targets and
testing the RTL or assembly dumps.
So, I'd use the testcase from the PR and probably scan the combine dump
and probably make it target dependent. If the combine dump isn't
particularly good to search for some reason, scan the assembly output.
jeff
