Yes, this needs to be fixed on trunk too. I looked at the history and it has been this way (overwriting the footer) for years. It must be uncommon to have this confluence of events.
Thanks, Teresa On Fri, Oct 3, 2014 at 9:28 AM, Xinliang David Li <davi...@google.com> wrote: > This patch should be targeting trunk gcc? > > David > > On Fri, Oct 3, 2014 at 9:23 AM, Rong Xu <x...@google.com> wrote: >> Hi, >> >> This patch fixed a bug exposed in build kernel with fdo. >> >> We cannot simply overwrite the bb footer in emit_barrier_after_bb as >> the bb may already have a footer (in this case, a deleted label stmt). >> We need to output this label because it's a user label and debug_info >> has a reference to it. >> >> Tested with problematic file and regression test. >> Trunk may also have the same issue, but I need to work on a testcase. >> >> Thanks, >> >> -Rong -- Teresa Johnson | Software Engineer | tejohn...@google.com | 408-460-2413