On Mon, Oct 06, 2014 at 11:54:00AM +0200, Marek Polacek wrote: > Java testsuite breaks with -std=gnu11 as a default and/or with > -Wimplicit-function-declaration on, since the jvgenmain.c program > that generates a C file containing 'main' function which calls either > 'JvRunMainName' or 'JvRunMain' does not generate forward declarations > for these functions. The fix is obvious IMHO. > > Bootstrapped/regtested on x86_64-linux, ok for trunk?
I cannot approve (java) patches, but it does look ok to me. With one nitpick. JvRunMain is only used when -findirect-dispatch is given, and otherwise JvRunMainName is used. So you could output only the actually used forward declaration by checking if (indirect). If no java maintainer responds, try CCing java-patc...@gcc.gnu.org to draw their attention. Cheers, Mark