Re: [PATCH 0/17] KASan 4.9 backport

[Yury Gribov]

On 10/17/2014 06:18 PM, Jakub Jelinek wrote:

On Fri, Oct 17, 2014 at 06:15:11PM +0400, Yury Gribov wrote:

On 10/17/2014 05:49 PM, Jakub Jelinek wrote:

Plus if you add misalign tests...

Sure, can do this on Monday.

Ok, thanks.

-  bool use_calls = ASAN_INSTRUMENTATION_WITH_CALL_THRESHOLD < INT_MAX
-    && asan_num_accesses >= ASAN_INSTRUMENTATION_WITH_CALL_THRESHOLD;
+  bool use_calls
+    = ASAN_INSTRUMENTATION_WITH_CALL_THRESHOLD < INT_MAX
+      && (flag_sanitize & SANITIZE_KERNEL_ADDRESS)
+      && asan_num_accesses >= ASAN_INSTRUMENTATION_WITH_CALL_THRESHOLD;

I agree that original code didn't quite match GNU conventions but can we
avoid reformatting it to make future backports easier? So e.g.

  bool use_calls = ASAN_INSTRUMENTATION_WITH_CALL_THRESHOLD < INT_MAX
+    && (flag_sanitize & SANITIZE_KERNEL_ADDRESS)
    && asan_num_accesses >= ASAN_INSTRUMENTATION_WITH_CALL_THRESHOLD;

I can live with that.  So here is updated patch:

Thanks, LGTM.

-Y