On Oct 21, 2014, at 9:11 PM, Richard Sandiford <richard.sandif...@arm.com> 
wrote:

> Maxim Kuvyrkov <maxim.kuvyr...@linaro.org> writes:
>> This patch improves model_order_p to use non-reg-pressure version of
>> rank_for_schedule when it needs to break the tie.  At the moment it is
>> comparing INSN_PRIORITY by itself, and it seems prudent to outsource
>> that to rank_for_schedule.
> 
> Do you have an example of where this helps?  A possible danger is that
> rank_for_schedule might (indirectly) depend on state that isn't maintained
> or updated in the same way during the model schedule phase.

I don't have an example where this patch helps, and I consider this patch a 
general cleanup.  From what I can see, all scheduler data structures are 
maintained during reg_sched_model scheduling.

Thank you,

--
Maxim Kuvyrkov
www.linaro.org

Reply via email to