RE: [Ping] [PATCH, 2/10] prepare ccmp

[Zhenqiang Chen]

> -----Original Message-----
> From: Richard Henderson [mailto:r...@redhat.com]
> Sent: Monday, October 27, 2014 11:14 PM
> To: Zhenqiang Chen
> Cc: gcc-patches@gcc.gnu.org
> Subject: Re: [Ping] [PATCH, 2/10] prepare ccmp
> 
> On 10/27/2014 12:48 AM, Zhenqiang Chen wrote:
> >> > On 09/22/2014 11:43 PM, Zhenqiang Chen wrote:
> >>> > > +       /* If jumps are cheap and the target does not support
> conditional
> >>> > > +          compare, turn some more codes into jumpy sequences.
> */
> >>> > > +       else if (BRANCH_COST (optimize_insn_for_speed_p (), false)
> < 4
> >>> > > +                && (targetm.gen_ccmp_first == NULL))
> >> >
> >> > Don't add unnecessary parenthesis around the == expression.
> >> >
> >> > Otherwise ok.
> >> >
> >> >
> >> > r~
> >
> > 2-prepare.patch
> >
> >
> > diff --git a/gcc/cfgexpand.c b/gcc/cfgexpand.c index 5200053..cfd4070
> > 100644
> > --- a/gcc/cfgexpand.c
> > +++ b/gcc/cfgexpand.c
> > @@ -2115,9 +2115,10 @@ expand_gimple_cond (basic_block bb, gimple
> stmt)
> >           op0 = gimple_assign_rhs1 (second);
> >           op1 = gimple_assign_rhs2 (second);
> >         }
> > -     /* If jumps are cheap turn some more codes into
> > -        jumpy sequences.  */
> > -     else if (BRANCH_COST (optimize_insn_for_speed_p (), false) < 4)
> > +     /* If jumps are cheap and the target does not support conditional
> > +        compare, turn some more codes into jumpy sequences.  */
> > +     else if ((BRANCH_COST (optimize_insn_for_speed_p (), false) < 4)
> > +              && (!targetm.gen_ccmp_first))
> 
> Did you not understand what I meant by parenthesis?

Thanks! Patch is updated.

-Zhenqiang

 

2-prepare.patch
Description: Binary data