On Wed, 2014-10-29 02:23:31 +0100, Jan-Benedict Glaw <jbg...@lug-owl.de> wrote: > On Wed, 2014-10-08 18:50:32 +0100, Joern Rennecke > <joern.renne...@embecosm.com> wrote: > > Attached is the GCC patch for the basic device package infrastructure. > > OK to apply? > > There's some fallout on config-list.mk builds: > > g++ -c -g -O2 -DIN_GCC -DCROSS_DIRECTORY_STRUCTURE -fno-exceptions > -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing > -Wwrite-strings -Wcast-qual -Wmissing-format-attribute -Woverloaded-virtual > -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -Werror > -fno-common -DHAVE_CONFIG_H -I. -I. -I../../../gcc/gcc -I../../../gcc/gcc/. > -I../../../gcc/gcc/../include -I../../../gcc/gcc/../libcpp/include > -I/opt/cfarm/mpc/include -I../../../gcc/gcc/../libdecnumber > -I../../../gcc/gcc/../libdecnumber/dpd -I../libdecnumber > -I../../../gcc/gcc/../libbacktrace -I. -I. -I../../../gcc/gcc > -I../../../gcc/gcc/. -I../../../gcc/gcc/../include > -I../../../gcc/gcc/../libcpp/include -I/opt/cfarm/mpc/include > -I../../../gcc/gcc/../libdecnumber -I../../../gcc/gcc/../libdecnumber/dpd > -I../libdecnumber -I../../../gcc/gcc/../libbacktrace > ../../../gcc/gcc/config/avr/driver-avr.c > ../../../gcc/gcc/config/avr/driver-avr.c:35:1: error: ‘void > avr_set_current_device(const char*)’ defined but not used > [-Werror=unused-function] > avr_set_current_device (const char *name) > ^ > cc1plus: all warnings being treated as errors > make[2]: *** [driver-avr.o] Error 1 > > See build > http://toolchain.lug-owl.de/buildbot/show_build_details.php?id=370682 > > Is it planned to use that function later on? Or shall we just drop it?
So I suggest to just remove it. 2014-10-29 Jan-Benedict Glaw <jbg...@lug-owl.de> * config/avr/driver-avr.c (avr_set_current_device): Remove. diff --git a/gcc/config/avr/driver-avr.c b/gcc/config/avr/driver-avr.c index 24a26d4..50de944 100644 --- a/gcc/config/avr/driver-avr.c +++ b/gcc/config/avr/driver-avr.c @@ -28,22 +28,3 @@ const avr_arch_t *avr_current_arch = NULL; /* Current device. */ const avr_mcu_t *avr_current_device = NULL; - -/* Initialize avr_current_arch and avr_current_device variables. */ - -static void -avr_set_current_device (const char *name) -{ - - if (NULL != avr_current_arch) - return; - - for (avr_current_device = avr_mcu_types; avr_current_device->name; - avr_current_device++) - { - if (strcmp (avr_current_device->name, name) == 0) - break; - } - - avr_current_arch = &avr_arch_types[avr_current_device->arch]; -} -- Jan-Benedict Glaw jbg...@lug-owl.de +49-172-7608481 Signature of: Friends are relatives you make for yourself. the second :
signature.asc
Description: Digital signature