On 10/29/14 04:28, Jakub Jelinek wrote:
On Tue, Oct 28, 2014 at 05:36:50PM +0000, Phil Muldoon wrote:
On 28/10/14 13:19, Joseph S. Myers wrote:
I'm seeing a different bootstrap failure from those already discussed:

In file included from
/scratch/jmyers/fsf/gcc-mainline/libcc1/../gcc/gcc-plugin.h:28:0,
                  from
/scratch/jmyers/fsf/gcc-mainline/libcc1/plugin.cc:34:
/scratch/jmyers/fsf/gcc-mainline/libcc1/../gcc/system.h:653:17: fatal error: 
gmp.h: No such file or directory

It appears the build is ignoring the --with-gmp option passed to
configure.  Since <gmp.h> is included in system.h, if you include system.h
you have to pass the right -I option corresponding to --with-gmp /
--with-gmp-include.  (There are several other such configure options for
MPFR, MPC, CLooG, ISL, libiconv at least - whether they are relevant
depends on whether your code ends up including the relevant headers.)

Hi, sorry for the troubles! I am having difficulty seeing this fail on
my system.  I built gmp from upstream, installed it, and pointed to
the install location with --with-gmp. Which stage does your build fail
at?

I am actually not totally sure how to respect the -with-gmp argument
in libcc1.  auto* tools are not my strongest skill. ;)

I notice gcc/configure.ac I think just exports the variables to
Makefile.in from the main configure script.  That what we should do in
this case?

Here is a patch I'm bootstrapping/regtesting now (but, with system gmp
installed).  I've verified that with this patch stage1 libcc1 is built
without -Werror in flags, while stage2 libcc1 is built with -Werror.

If this passes bootstrap/regtest, is it ok for trunk (should fix
two bootstrap issues)?  Is the
https://gcc.gnu.org/ml/gcc-patches/2014-10/msg02936.html
patch ok too (that one already tested; another bootstrap issue)?

2014-10-29  Jakub Jelinek  <ja...@redhat.com>
            Phil Muldoon  <pmuld...@redhat.com>

        * configure.ac: Remove -Werror addition to WARN_FLAGS.  Add
        ACX_PROG_CC_WARNINGS_ARE_ERRORS and AC_ARG_VAR for GMPINC.
        * Makefile.am (AM_CPPFLAGS): Add $(GMPINC).
        (WERROR_FLAG): Remove.
        (AM_CXXFLAGS): Use $(WERROR) instead of $(WERROR_FLAG).
        * configure: Regenerated.
        * Makefile.in: Regenerated.
So is this still relevant if we stop bootstrapping libcc1?

The patch is OK if it's still needed.

Thanks,
Jeff


Reply via email to