On Fri, 2014-10-31 at 15:29 -0600, Jeff Law wrote:
> On 10/31/14 11:02, David Malcolm wrote:
> > The "intro" subdirectory of gcc/jit/docs consists of a 4-part tutorial
> > aimed at experienced developers who are new users of the library, taking
> > them from beginning use all the way up to adding JIT-compilation to an
> > interpreter.
> >
> > gcc/jit/
> > * docs/intro/factorial.png: New.
> > * docs/intro/index.rst: New.
> > * docs/intro/sum-of-squares.png: New.
> > * docs/intro/tutorial01.rst: New.
> > * docs/intro/tutorial02.rst: New.
> > * docs/intro/tutorial03.rst: New.
> > * docs/intro/tutorial04.rst: New.
> I'm not actually reviewing the .rst bits, but instead looking at the
> generate docs -- and I'm mostly just looking at them from a higher level
> (ie, what belongs, what doesn't and such). Given you've addressed the
> issues raised earlier I don't expect further changes in this area.
>
> Patches 23, 24, 25 are all OK.
>
> I don't see #26 or #27 in the series? Were they particularly large?
Yes: I deliberately didn't send 19, 26, 27 as they were large (170k and
up), and are essentially already approved:
-rw-rw-r--. 1 david david 267546 Oct 31 12:35 0019-Testsuite-for-the-JIT.patch
-rw-rw-r--. 1 david david 177604 Oct 31 12:35
0026-Prebuilt-texinfo-documentation-for-the-JIT-library.patch
-rw-rw-r--. 1 david david 188093 Oct 31 12:35 0027-ChangeLog-files.patch
(and it's all in git, fwiw).
Some notes on each of these:
re [PATCH 19/27] Testsuite for the JIT
An earlier version of this was posted as:
"[PATCH 07/10] Testsuite for the JIT (Re: Patches 5-10 of jit merger (was:
Re: [PATCH 0/5] Merger of jit branch (v2)))"
https://gcc.gnu.org/ml/gcc-patches/2014-10/msg01248.html
which you approved in
https://gcc.gnu.org/ml/gcc-patches/2014-10/msg01413.html
with:
> OK when rest of JIT bits are approved.
> I just did some very rough sanity checking -- the details of the
> testsuite I'm totally leaving in your hands :-)
The only changes have been to jit.exp, to handle running the
testsuite without needing to install.
re [PATCH 26/27] Prebuilt texinfo documentation for the JIT library
This is for the benefit of those without Sphinx installed,
and is autogenerated by running "make texinfo" in the gcc/jit/docs
subdirectory.
I posted an earlier version of this as:
"[PATCH 09/10] Prebuilt texinfo documentation for the JIT library (Re:
Patches 5-10 of jit merger)"
https://gcc.gnu.org/ml/gcc-patches/2014-10/msg01395.html
which you approved in https://gcc.gnu.org/ml/gcc-patches/2014-10/msg01415.html
> Assuming these are built from the sphinx stuff, these are fine
> once the rest of the JIT stuff is approved -- as it updating these
> things if there's any updates necessary to the source sphinx
> documentation.
which preapproves this updated version.
re [PATCH 27/27] ChangeLog files
The dmalcolm/jit branch has ChangeLog.jit files describing the
history of the branch. Add them to trunk for the record.
Also, there will be a gcc/jit/ChangeLog.
I posted an earlier version of this as:
"[PATCH 10/10] ChangeLog files (Re: Patches 5-10 of jit merger (was: Re:
[PATCH 0/5] Merger of jit branch (v2)))"
https://gcc.gnu.org/ml/gcc-patches/2014-10/msg01250.html
which you approved in
https://gcc.gnu.org/ml/gcc-patches/2014-10/msg01416.html :
> OK once the rest of the JIT stuff is approved.
> Not going to look at these in any detail.
Relative to that, this version merely adds new entries for the work
I've done on the branch since the original merger request, and is
thus presumably an obvious change.
Do you need me to post anything more for these three?
Thanks
Dave
