On Thu, Nov 06, 2014 at 10:06:00AM +0100, Thomas Schwinge wrote: > Hi Julian! > > On Wed, 5 Nov 2014 17:57:10 +0000, Julian Brown <jul...@codesourcery.com> > wrote: > > This patch moves plugin-nvptx.c and plugin-host.c (from oacc-host.c) > > into a new "plugin" subdirectory, as requested by Jakub, and to match > > more closely the layout of the Intel MIC pieces. This also moves the > > autotools bits to enable the NVPTX plugin and locate CUDA libraries > > into the plugin directory's (new) configury bits. > > Hmm. And then we "cross-include" files in libgomp/ from libgomp/plugin/ > as well as the other way round (libgomp/oacc-host.c including > libgomp/plugin/plugin-host.c, for example) -- whilst these two "regimes" > are configured by two separate Autoconf instances? Is this really the > intended scheme, or should we maybe rather have a top-level libgomp > Autoconf/Automake system (as before), which is amended by > libgomp/plugin/configfrag.ac and libgomp/plugin/Makefrag.am files that > are included from libgomp/configure.ac and libgomp/Makefile.am?
I agree a plugin fragment into libgomp/configure.ac and/or libgomp/Makefile* is better. Jakub