On 11/05/14 12:34, David Malcolm wrote:
I've added comments throughout the file.
I didn't bother adding __attribute__((cold)), instead simply dropping
that "TODO".
Fine.
Attached is the current state of the file gcc/jit/libgccjit.c (on the
branch) for review.
OK for trunk? (conditional on all the rest being approved, and usual
bootstrap®rtesting; I've merely verified a non-bootstrap compile and
successful make check-jit so far).
There were a few other changes relative to what you've approved, which
I'll post for review shortly.
Dave
libgccjit.c
/* Implementation of the C API; all wrappers into the internal C++ API
Copyright (C) 2013-2014 Free Software Foundation, Inc.
Contributed by David Malcolm<dmalc...@redhat.com>.
This is fine. With the comments, it became a lot clearer this was just
the error checking wrappers and not a whole lot else.
The one thing this does make me wonder is should we add something about
the error checking may change in significant ways from one release to
the next, much like the ABI/API.
This seems important as the error checking in many ways specifies the
language for the JIT and I suspect we haven't got all the corner cases
sorted out yet (and probably can't until this gets into wider distribution).
jeff