On Mon, Nov 10, 2014 at 05:34:30PM +0300, Ilya Verbin wrote:
> > I don't like this, that is too fragile.  If automake is changed, we'll
> > forget to update this.
> > If all you are about are the 3 additional variables, can't you instead
> > put them into env vars and query them in the tcl code using getenv?
> > Or append them into AM_RUNTESTFLAGS ?
> > AM_RUNTESTFLAGS += @something@
> 
> Done, I put them into env vars.

Thanks.

> > > +    lappend ALWAYS_CFLAGS 
> > > "additional_flags=${offload_additional_options}"
> > >  }
> > 
> > Perhaps add this only if offload_additional_options is non-empty?
> 
> Done.

Ok for trunk.

        Jakub

Reply via email to