> > -----Original Message-----
> > From: Matthew Fortune [mailto:matthew.fort...@imgtec.com]
> > Sent: Tuesday, November 18, 2014 12:22 PM
> > To: Rozycki, Maciej
> > Cc: gcc-patches@gcc.gnu.org; Moore, Catherine; Eric Christopher
> > Subject: RE: [PATCH] MIPS/GCC: Unconditional jump generation bug fix
> >
> > Maciej W. Rozycki <ma...@codesourcery.com> writes:
> > > On Mon, 17 Nov 2014, Matthew Fortune wrote:
> > >
> > > > >       gcc/
> > > > >       * gcc/config/mips/mips.md (*jump_absolute): Use a branch when
> in
> > > > >       range, a jump otherwise.
> > > >
> > > > OK.
> > > >
> > > > I only got my head around this code last week otherwise I wouldn't
> > > > have known whether this was correct!
> > >
> > >  Committed now, thanks for your review.  How about 4.9? -- once it
> > > is unfrozen, that is.
> >
> > I admit to being a bit more nervous about 4.9 but the test coverage
> > seems thorough enough. I guess I would have been less concerned if the
> > optimisation was still just tied to TARGET_MICROMIPS for the 4.9
> branch.
> >
> > Catherine, what do you think?
> >
> This is okay for 4.9 IMO.

OK

Matthew

Reply via email to