Andrew Pinski <pins...@gmail.com> writes: > On Wed, Nov 12, 2014 at 2:56 PM, Matthew Fortune > <matthew.fort...@imgtec.com> wrote: > >> > Moore, Catherine <catherine_mo...@mentor.com> writes: > >> > > The patch looks good. Please fix up these couple of nits prior to > >> > > committing. > >> > > >> > OK, thanks for the second read through. One further amendment > >> > below, I'll aim to commit later today. > >> > > >> > >> Yes, that's better. > > > > Committed as r217446 > > > > Fingers crossed there will be no fallout from it but if there is I'll > > deal with it promptly. > > Most of the testcases fail if you are compiling for soft-float: > FAIL: gcc.target/mips/call-clobbered-1.c -O1 scan-assembler-times sdc1 2 > FAIL: gcc.target/mips/call-clobbered-1.c -O1 scan-assembler-times ldc1 4 > ... > FAIL: gcc.target/mips/call-clobbered-2.c -O1 scan-assembler-times lwc1 4 > FAIL: gcc.target/mips/call-clobbered-2.c -O1 scan-assembler-times swc1 2 > ... > > FAIL: gcc.target/mips/call-clobbered-3.c -O1 scan-assembler-times lwc1 5 > FAIL: gcc.target/mips/call-clobbered-3.c -O1 scan-assembler-times swc1 3 > ... > FAIL: gcc.target/mips/call-clobbered-4.c -Os scan-assembler-times lwc1 4 > FAIL: gcc.target/mips/call-clobbered-4.c -Os scan-assembler-times swc1 2 > ... > FAIL: gcc.target/mips/call-saved-4.c -O0 scan-assembler \\\\\$f20 > FAIL: gcc.target/mips/call-saved-4.c -O0 scan-assembler \\\\\$f22 > FAIL: gcc.target/mips/call-saved-4.c -O0 scan-assembler \\\\\$f24 > FAIL: gcc.target/mips/call-saved-4.c -O0 scan-assembler \\\\\$f26 > FAIL: gcc.target/mips/call-saved-4.c -O0 scan-assembler \\\\\$f28 > FAIL: gcc.target/mips/call-saved-4.c -O0 scan-assembler \\\\\$f30 > .... > > FAIL: gcc.target/mips/call-saved-5.c -O0 scan-assembler \\\\\$f20 > FAIL: gcc.target/mips/call-saved-5.c -O0 scan-assembler \\\\\$f22 > FAIL: gcc.target/mips/call-saved-5.c -O0 scan-assembler \\\\\$f24 > FAIL: gcc.target/mips/call-saved-5.c -O0 scan-assembler \\\\\$f26 > FAIL: gcc.target/mips/call-saved-5.c -O0 scan-assembler \\\\\$f28 > FAIL: gcc.target/mips/call-saved-5.c -O0 scan-assembler \\\\\$f30 > ... > FAIL: gcc.target/mips/movdf-1.c -O1 scan-assembler-times ldc1 1 > ... > FAIL: gcc.target/mips/movdf-2.c -O1 scan-assembler mthc1 > FAIL: gcc.target/mips/movdf-2.c -O1 scan-assembler mtc1 > ... > FAIL: gcc.target/mips/movdf-3.c -O1 scan-assembler-times mtc1 2 > ...
Thanks Andrew. I'll take a look, getting these tests to be usable in all the hardfloat configs took such a long time that I have clearly not run the single or soft float configs. My intention was to make mips.exp intelligent enough to know that -mfp* imply -mdouble-float and -mhard-float which should resolve this. I would also add -msingle-float support but single-float has been ignored for a number of tests so I'll look at that separately. It will take a couple of days to go through the configs to make sure I don’t break the tests for hard-float configs with the change. Matthew
