On 11/23/14 21:11, tsaund...@mozilla.com wrote:
From: Trevor Saunders <tsaund...@mozilla.com>
Hi,
The one interesting part of this is what we do about plugins. As you can tell
from the diff removing support for these gengtype features makes things much
simpler, and I think the only way to do that is to remove the plugin hook for
adding caches. Plugins should be fine converting to the new scheme with
hash_table we use in gcc so long as they can hook in at a point where they can
drop caches, and mark objects they need to stay alive. Its a little odd, but
the PLUGIN_GGC_MARKING hook is actually called at a point they can do both. We
could add a separate PLUGIN_GGC_DROP_CACHES hook, but I'm not sure what the
point would be.
Trev
gcc/
* plugin.c, plugin.def, ggc.h, ggc-common.c, gengtype.h, gengtype.c,
gengtype-state.c, gengtype-parse.c, gentype-lex.l, gcc-plugin.h,
doc/plugins.texi, doc/gty.texi: Remove support for if_marked and
param_is.
include/
* hashtab.h, splay-tree.h: Remove GTY markers.
I can't seem to find our porting-to document yet and I think this
deserves a mention there. Can you contact Jon and see if he's pulling
something together in that space (I suspect he is due to the C++ ABI
library changes).
I'm OK with this patch as I'd prefer to get the old interfaces to the GC
system cleaned up now rather than waiting another release.
Give Richi and others as chance to object, but if they don't whenin the
next couple days, go ahead and check it in.
jeff
