On Thu, Nov 27, 2014 at 7:32 AM, Renlin Li <renlin...@arm.com> wrote:
> On 26/11/14 18:12, H.J. Lu wrote:
>>
>> On Wed, Nov 26, 2014 at 10:09 AM, Renlin Li <renlin...@arm.com> wrote:
>>>
>>> On 26/11/14 12:16, H.J. Lu wrote:
>>>>
>>>> On Wed, Nov 26, 2014 at 4:07 AM, Renlin Li <renlin...@arm.com> wrote:
>>>>>
>>>>> On 20/11/14 16:17, Renlin Li wrote:
>>>>>>
>>>>>> Hi all,
>>>>>>
>>>>>> This is a backport for gcc-4_9-branch of the patch "[PR63762]GCC
>>>>>> generates
>>>>>> UNPREDICTABLE STR with Rn = Rt for arm" posted in:
>>>>>> https://gcc.gnu.org/ml/gcc-patches/2014-11/msg02253.html
>>>>>>
>>>>>> arm-none-eabi has been test on the model, no new issues. bootstrapping
>>>>>> and
>>>>>> regression tested on x86, no new issues.
>>>>>>
>>>>>> Is it Okay for gcc-4_9-branch?
>>>>>>
>>>>>> gcc/ChangeLog:
>>>>>>
>>>>>> 2014-11-20  Renlin Li  <renlin...@arm.com>
>>>>>>
>>>>>>       PR middle-end/63762
>>>>>>       * ira.c (ira): Update preferred class.
>>>>>>
>>>>>> gcc/testsuite/ChangeLog:
>>>>>>
>>>>>> 2014-11-20  Renlin Li  <renlin...@arm.com>
>>>>>>
>>>>>>       PR middle-end/63762
>>>>>>       * gcc.dg/pr63762.c: New.
>>>>>
>>>>> Ping for it.
>>>>>
>>>> Please verify if it is the real fix for
>>>>
>>>> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63661
>>>>
>>>> If yes, please add a testcase for PR 63661 and mention it in
>>>> your ChangeLog entry.
>>>>
>>>> Thanks.
>>>>
>>>>
>>> Hi H.J.
>>>
>>> Yes, I have verified that, this patch additionally fixes PR 63661.
>>>
>>> I observed the same behaviour as I saw on arm backend. It will be great
>>> if
>>> you can double check they are caused by exactly the same reason.
>>
>> I will ask our people to take a look.
>>
>>>
>>> A new testcase has been added, ChangeLog has been updated to reflect the
>>> change. Updated patch has bee attached.
>>> Okay for gcc-4_9-branch?
>>>
>>> Regards,
>>> Renlin Li
>>>
>>>
>>> gcc/ChangeLog:
>>>
>>> 2014-11-26  Renlin Li  <renlin...@arm.com>
>>>
>>>      PR middle-end/63762
>>>      PR middle-end/63661
>>>      * ira.c (ira): Update preferred class.
>>>
>>> gcc/testsuite/ChangeLog:
>>>
>>> 2014-11-26  Renlin Li  <renlin...@arm.com>
>>>
>>>      PR middle-end/63661
>>>      PR middle-end/63762
>>>      * testsuite/gcc.dg/pr63661.c: New.
>>>      * testsuite/gcc.dg/pr63762.c: New.
>>>
>>>
>> pr63661.c should be moved to gcc.target/i386 and run it
>> on PIC target.
>>
>> Thanks.
>>
> Hi H.J.
>
> The patch has been adjusted according to your suggestion.
>
>
> gcc/ChangeLog:
>
> 2014-11-27  Renlin Li  <renlin...@arm.com>
>
>     PR middle-end/63762
>     PR target/63661
>     * ira.c (ira): Update preferred class.
>
> gcc/testsuite/ChangeLog:
>
> 2014-11-27  Renlin Li  <renlin...@arm.com>
>
>     PR middle-end/63762
>     PR target/63661
>     * testsuite/gcc.dg/pr63762.c: New.
>     * testsuite/gcc.target/i386/pr63661.c: New.
        ^^^^^^^^^^^  No testsuite/
>

gcc.target/i386/pr63661.c should be checked into trunk first.

-- 
H.J.

Reply via email to