On Mon, 2014-12-01 14:52:05 +0100, Jakub Jelinek <ja...@redhat.com> wrote: > On Fri, Nov 28, 2014 at 08:02:23PM +0100, Jakub Jelinek wrote: > > As possible follow-up, I wonder if gimple_build_assign_with_ops > > isn't too long and too verbose either, couldn't we just > > use overloads of gimple_build_assign instead? > > Either with the argument order of gimple_build_assign_with_ops, > > i.e. tree_code, lhs, operands... , or perhaps swap the lhs and > > tree_code, so lhs, tree_code, operands... In either case, I'd > > find it to be pretty much unambiguous with the current two operand > > gimple_build_assign which takes lhs, treeop, the presence of > > enum tree_code would make it obvious that you are supplying ops for it > > rather than building it from what is extracted from the tree. > > The following patch implements that. Bootstrapped/regtested on x86_64-linux > and i686-linux, ok for trunk?
Seems this caused some fallout for aarch64_be-elf, see eg. http://toolchain.lug-owl.de/buildbot/show_build_details.php?id=380617 : g++ -c -g -O2 -DIN_GCC -DCROSS_DIRECTORY_STRUCTURE -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wwrite-strings -Wcast-qual -Wmissing-format-attribute -Woverloaded-virtual -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -fno-common -DHAVE_CONFIG_H -I. -I. -I/home/jbglaw/repos/gcc/gcc -I/home/jbglaw/repos/gcc/gcc/. -I/home/jbglaw/repos/gcc/gcc/../include -I/home/jbglaw/repos/gcc/gcc/../libcpp/include -I/opt/cfarm/gmp-latest/include -I/opt/cfarm/mpfr-latest/include -I/opt/cfarm/mpc-latest/include -I/home/jbglaw/repos/gcc/gcc/../libdecnumber -I/home/jbglaw/repos/gcc/gcc/../libdecnumber/dpd -I../libdecnumber -I/home/jbglaw/repos/gcc/gcc/../libbacktrace -o aarch64.o -MT aarch64.o -MMD -MP -MF ./.deps/aarch64.TPo /home/jbglaw/repos/gcc/gcc/config/aarch64/aarch64.c /home/jbglaw/repos/gcc/gcc/wide-int.h: In function ‘bool aarch64_float_const_representable_p(rtx_def*)’: /home/jbglaw/repos/gcc/gcc/wide-int.h:798: warning: array subscript is above array bounds /bin/bash /home/jbglaw/repos/gcc/gcc/config/aarch64/geniterators.sh \ /home/jbglaw/repos/gcc/gcc/config/aarch64/iterators.md > \ aarch64-builtin-iterators.h g++ -c -g -O2 -DIN_GCC -DCROSS_DIRECTORY_STRUCTURE -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wwrite-strings -Wcast-qual -Wmissing-format-attribute -Woverloaded-virtual -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -fno-common -DHAVE_CONFIG_H -I. -I. -I/home/jbglaw/repos/gcc/gcc -I/home/jbglaw/repos/gcc/gcc/. -I/home/jbglaw/repos/gcc/gcc/../include -I/home/jbglaw/repos/gcc/gcc/../libcpp/include -I/opt/cfarm/gmp-latest/include -I/opt/cfarm/mpfr-latest/include -I/opt/cfarm/mpc-latest/include -I/home/jbglaw/repos/gcc/gcc/../libdecnumber -I/home/jbglaw/repos/gcc/gcc/../libdecnumber/dpd -I../libdecnumber -I/home/jbglaw/repos/gcc/gcc/../libbacktrace -I. -I. -I/home/jbglaw/repos/gcc/gcc -I/home/jbglaw/repos/gcc/gcc/. -I/home/jbglaw/repos/gcc/gcc/../include -I/home/jbglaw/repos/gcc/gcc/../libcpp/include -I/opt/cfarm/gmp-latest/include -I/opt/cfarm/mpfr-latest/include -I/opt/cfarm/mpc-latest/include -I/home/jbglaw/repos/gcc/gcc/../libdecnumber -I/home/jbglaw/repos/gcc/gcc/../libdecnumber/dpd -I../libdecnumber -I/home/jbglaw/repos/gcc/gcc/../libbacktrace \ /home/jbglaw/repos/gcc/gcc/config/aarch64/aarch64-builtins.c /home/jbglaw/repos/gcc/gcc/config/aarch64/aarch64-builtins.c: In function ‘bool aarch64_gimple_fold_builtin(gimple_stmt_iterator*)’: /home/jbglaw/repos/gcc/gcc/config/aarch64/aarch64-builtins.c:1329: error: ‘gimple_build_assign_with_ops’ was not declared in this scope make[1]: *** [aarch64-builtins.o] Error 1 make[1]: Leaving directory `/home/jbglaw/build/aarch64_be-elf/build-gcc/gcc' make: *** [all-gcc] Error 2 MfG, JBG -- Jan-Benedict Glaw jbg...@lug-owl.de +49-172-7608481 Signature of: ...und wenn Du denkst, es geht nicht mehr, the second : kommt irgendwo ein Lichtlein her.
signature.asc
Description: Digital signature
