On Tue, Dec 2, 2014 at 11:19 AM, Uros Bizjak <ubiz...@gmail.com> wrote: > Hello! > >> Ping. >>> Ping. >>>> Ping. >>>>> Ping. > > It would probably help reviewers if you pointed to actual path > submission [1], which unfortunately contains the explanation in the > patch itself [2], which further explains that this functionality is > currently only supported with gold, patched with [3]. > > [1] https://gcc.gnu.org/ml/gcc-patches/2014-09/msg00645.html > [2] https://gcc.gnu.org/ml/gcc-patches/2014-09/txt2CHtu81P1O.txt > [3] https://sourceware.org/ml/binutils/2014-05/msg00092.html > > After a bit of the above detective work, I think that new gcc option > is not necessary. The configure should detect if new functionality is > supported in the linker, and auto-configure gcc to use it when > appropriate. > > I have also added a couple of linker experts in the CC.
I don't think i386_binds_local_p is correct. What does it return for hidden external variable? I think it should be bool local = default_binds_local_p (exp); if (!local) local = ... return local; H.J.
