On Wed, Dec 03, 2014 at 12:04:13PM +0300, Yury Gribov wrote:
> On 12/03/2014 11:36 AM, Jakub Jelinek wrote:
> >I thought I've agreed that we can optimize checks away for asan even when
> >recovering. The patch is ok for trunk anyway, we can perhaps make it
> >tunable later, or define asan_can_optimize_checks to true unconditionally.
>
> Snap, looks like my English failed me.
I've been against it in several mails, but then you mentioned we do it
anyway in asan.c already for the local optimization and I've changed my mind
afterwards. Perhaps you've missed the last mail?
> How about this one? I only checked
> asan.exp but the change looks really trivial (drop asan_can_optimize_checks
> and change asan_check_optimize).
Ok, thanks.
> >From 3bca06f351ed9a7c34f74c30951a7b3cd4907e74 Mon Sep 17 00:00:00 2001
> From: Yury Gribov <y.gri...@samsung.com>
> Date: Tue, 25 Nov 2014 11:49:11 +0300
> Subject: [PATCH] 2014-12-03 Yury Gribov <y.gri...@samsung.com>
>
> gcc/
> * sanopt.c (maybe_get_single_definition): New function.
> (can_remove_asan_check): Ditto.
> (struct tree_map_traits): New struct.
> (struct sanopt_ctx): Use custom traits for asan_check_map.
> (maybe_get_dominating_check): New function.
> (maybe_optimize_ubsan_null_ifn): Move code to
> maybe_get_dominating_check.
> (maybe_optimize_asan_check_ifn): Move code and take non-SSA expressions
> into account when optimizing.
> (sanopt_optimize_walker): Optimize ASan checks even when
> recovering.
Jakub
