On Dec 8, 2014, at 12:44 PM, David Malcolm <dmalc...@redhat.com> wrote: > On Tue, 2014-11-25 at 20:34 -0500, David Malcolm wrote: >> Add command-line option-parsing to the testcases, so that we can >> manipulate them without needing a recompile (e.g. varying >> optimization levels etc). >> >> This uses getopt_long, which is a GNU extension to libc. Is that >> acceptable? > > Ping. Specifically, is it acceptable to use getopt_long within the jit > testcases, or should I find another way to do this (e.g. just getopt)?
So, the standard by which we measure, does it kill building or testing of ada on mingwin? If it does, then no, not acceptable. I’d like to think there is nothing you can do in jit.exp that could do that. So, from this perspective, yeah, feel free to do what you want. Git it done first. The second person that wants to port your code to a new machine (a different machine) will trip over all the bad things you did, and someone will then have to fix them. If you only use what gcc already sues, you will be portable to everything gcc is portable to. If you use GNU extensions to libc, well, that isn’t portable enough in general. Heck, even what’s in libc isn’t portable enough, that’s half the reason why we have autoconf in the first place. If jit is on by default everywhere, then you need to be portable everywhere. If only on for linux, then well, it already has GNU extensions in libc. I don’t know if it is on by default and you didn’t say, so, hard to comment on it.
