Hi,
On 12 Dec 09:17, Jakub Jelinek wrote:
> On Fri, Dec 12, 2014 at 09:14:28AM +0100, Thomas Schwinge wrote:
> > On Tue, 30 Sep 2014 13:16:37 +0200, I wrote:
> > > On Fri, 26 Sep 2014 16:36:21 +0400, Ilya Verbin <iver...@gmail.com> wrote:
> > > > --- a/configure.ac
> > > > +++ b/configure.ac
> > > > @@ -286,6 +286,24 @@ case ${with_newlib} in
> > > > yes) skipdirs=`echo " ${skipdirs} " | sed -e 's/ target-newlib / /'`
> > > > ;;
> > > > esac
> > > >
> > > > +AC_ARG_ENABLE(as-accelerator-for,
> > > > +[AS_HELP_STRING([--enable-as-accelerator-for=ARG],
> > > > + [build as offload target compiler.
> > > > + Specify offload host triple by ARG])],
> > > > +ENABLE_AS_ACCELERATOR_FOR=$enableval,
> > > > +ENABLE_AS_ACCELERATOR_FOR=no)
> > >
> > > I don't see $ENABLE_AS_ACCELERATOR_FOR being used anywhere, so this can
> > > probably be removed?
> >
> > On Wed, 1 Oct 2014 20:05:45 +0400, Ilya Verbin <iver...@gmail.com> wrote:
> > > It will be used in one of the upcoming patches.
> >
> > OK, but why do you need the all-uppercase variant? The lowercase
> > enable_as_accelerator_for already is (automatically) populated by
> > Autoconf, and used in other places? Here is a untested cleanup patch;
> > could you please test this?
> >
> > * configure.ac (--enable-as-accelerator-for): Don't set
> > ENABLE_AS_ACCELERATOR_FOR. Update all users.
> > * configure: Regenerate.
>
> Ok if it works.
The patch doesn't regress MIC offloading.
--
Thanks, K
>
> Jakub
