On 12/15/2014 03:42 AM, Dominik Vogt wrote: > On Fri, Dec 12, 2014 at 10:14:21AM -0800, Richard Henderson wrote: >> On 12/12/2014 04:06 AM, Dominik Vogt wrote: >>> I'm not sure I've posted the missing patch anywhere yet, so it's >>> attached to this message. At the moment it enables >>> FFI_TYPE_COMPLEX only for s390[x], but eventually this should be >>> used unconditionally. >> >> Thanks for that. I'd been meaning to get around to that. I'll change the >> test >> to use FFI_TARGET_HAS_COMPLEX_TYPE and apply it to my branch. > > Good. I'm not sure whether it's a good idea to expose > FFI_TARGET_HAS_COMPLEX_TYPE as part of the libffi interface > though. It was meant as a temporary thing to be removed once all > platforms supported by libffi have implemented complex support. A > while ago I've posted a patch to change the macro's name to begin > with an underscore to make that clearer.
It's our copy of libffi -- I think we can assume any internals we like. Similarly, when I finish writing the bits that allow libffi to handle empty structures, I don't plan to conditionalize libgo, I simply plan to assume it works. r~