On Wed, Dec 17, 2014 at 04:21:31PM -0500, Jason Merrill wrote: > On 11/27/2014 01:28 AM, tsaund...@mozilla.com wrote: > >+ if (warn_override && DECL_VIRTUAL_P (decl) && !DECL_OVERRIDE_P (decl) > > Why check DECL_VIRTUAL_P here?
I think it was to avoid warning when decl is hiding a non virtual method on the parent class, but I guess that won't happen anyway? so I'll remove it. Trev > > >+ warning_at(DECL_SOURCE_LOCATION (decl), OPT_Wsuggest_override, > > Space before the (. > > Jason >
