https://gcc.gnu.org/bugzilla/show_bug.cgi?id=122498

Thomas Schwinge <tschwinge at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://github.com/Rust-GCC
                   |                            |/gccrs/pull/4275

--- Comment #21 from Thomas Schwinge <tschwinge at gcc dot gnu.org> ---
(In reply to Arthur Cohen from comment #20)
> I slightly modified Thomas' patch to apply it to the offending file
> directly.

..., which is a header file, 'gcc/rust/ast/rust-fmt.h', so doesn't the '#pragma
GCC diagnostic [...]' then apply to all files that '#include' this one?

To make it more local, could we move the '#pragma' into the specific function
where we fail, wrapped in '#pragma GCC diagnostic push' and '#pragma GCC
diagnostic pop'?

(I'm not familiar with this.)


Generally, not specific to GCC/Rust, also see my comments in PR122197 "[16
Regression] predictively devirtualization vs middle-end warnings since
r16-4000".  Of course, I appreciate the idea to make the build functional
again, but that won't solve the underlying issue.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

Reply via email to