I'll guess it is not needed here, but otherwise <windows.h> defines the macros
max and min, they then conflict e.g. with C++'s std::max/std::min. So I consider
it best practice to always define it, before including <windows.h>.
Am 20.11.2023 um 21:07 schrieb Eli Zaretskii:
Date: Mon, 20 Nov 2023 20:57:38 +0100
Cc: [email protected], [email protected]
From: Björn Schäpers <[email protected]>
+#ifndef NOMINMAX
+#define NOMINMAX
+#endif
Why is this part needed?
Otherwise, LGTM, thanks. (But I'm don't have the approval rights, so
please wait for Ian to chime in.)
